Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set role=none in different place for ActionMenu form items #2828

Merged
merged 1 commit into from
May 8, 2024

Conversation

camertron
Copy link
Contributor

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

A recent PR added role="none" to forms that wrap ActionMenu items. Unfortunately this caused a few dotcom tests to fail because it appeared to supersede form arguments passed to individual items. I'm still not sure why, but moving the code into the FormWrapper fixed the problem.

Integration

No additional changes necessary in production.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Copy link

changeset-bot bot commented May 8, 2024

🦋 Changeset detected

Latest commit: 322b845

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@camertron camertron marked this pull request as ready for review May 8, 2024 22:41
@camertron camertron requested a review from a team as a code owner May 8, 2024 22:41
@camertron camertron requested a review from mperrotti May 8, 2024 22:41
@camertron camertron merged commit 9ca87d3 into main May 8, 2024
30 checks passed
@camertron camertron deleted the fix_action_menu_form_items branch May 8, 2024 22:45
@primer primer bot mentioned this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants