chore: moved from uint64 to uint256 #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikelle
force-pushed
the
feat/153/bid-uint64-to-uint256
branch
from
4f9ebde
to
e257a1d
Compare
Mikelle
force-pushed
the
feat/153/bid-uint64-to-uint256
branch
from
e257a1d
to
d87c868
Compare
ckartik
reviewed
Jun 19, 2024
| @@ -285,7 +287,7 @@ func TestUpdater(t *testing.T) { | |||
| if !bytes.Equal(settlement.builder, c.Commiter.Bytes()) { | |||
| t.Fatal("wrong builder") | |||
| } | |||
| if settlement.amount != 0 { | |||
| if settlement.amount.Uint64() != 10 { | |||
There was a problem hiding this comment.
why are you getting the Uint64 value here?
There was a problem hiding this comment.
Thank you for the review! This is for the test. The initial value is 10, so it can be converted to uint64 here.
ckartik
approved these changes
Jun 19, 2024
mrekucci
pushed a commit
that referenced
this pull request
Jun 21, 2024
* chore: moved from uint64 to uint256 * chore: fixed tests for the oracle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#153