Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect getSpotPrice #436

Closed
Alexangelj opened this issue Aug 21, 2023 · 2 comments · Fixed by #437
Closed

Incorrect getSpotPrice #436

Alexangelj opened this issue Aug 21, 2023 · 2 comments · Fixed by #437

Comments

@Alexangelj
Copy link
Contributor

portfolio/contracts/strategies/NormalStrategyLib.sol

Line 414 in 47d1e0b

if (reserveXPerWad >= upperBoundX) return self.strikePriceWad; // Terminal price limit.

If x has reached its upper bound, it should return a 0 price.
@Autoparallel
Copy link
Contributor

On it!

@Alexangelj
Copy link
Contributor Author

Note that is function is not relied upon in the codebase, it's only exposed to make it easier to get information from the pool.

@Autoparallel Autoparallel mentioned this issue Aug 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update NormalStrategyLib.sol primitivefinance/portfolio
2 participants
@Autoparallel @Alexangelj