Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reduce type constraints #233

Closed
wants to merge 1 commit into from
Closed

fix: reduce type constraints #233

wants to merge 1 commit into from

Conversation

forivall
Copy link
Contributor

See #232

@lpinca
Copy link
Member

lpinca commented Aug 25, 2020 •
edited

@gfmio are you ok with this? Is it different from #232?

@gfmio
Copy link
Contributor

gfmio commented Aug 25, 2020 •
edited

@lpinca Both type definitions do the exact same thing, so I'm fine with merging this. I've also verified manually once more that this code does in fact resolve the issue.

@lpinca
Copy link
Member

lpinca commented Aug 25, 2020

Both type definitions do the exact same thing.

Ok, I'll merge #232 then because it was submitted first.

@lpinca lpinca closed this Aug 25, 2020
@forivall forivall mentioned this pull request Aug 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@forivall @lpinca @gfmio