Add uws transformer #454
Merged
Add uws transformer #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
force-pushed
the
uws
branch
2 times, most recently
from
07795fc
to
be3d6e4
Compare
| // Listen to upgrade requests. | ||
| // | ||
| this.on('upgrade', function upgrade(req, soc, head) { | ||
| this.service.onConnection(function create(socket) { |
There was a problem hiding this comment.
I'm not totally happy with adding a new connection handler for each upgrade request, but right now this is what the interface offers.
There was a problem hiding this comment.
@3rd-Eden do you think it will be better to go with something like this https://github.com/alexhultman/uWebSockets/issues/45#issuecomment-208740046?
|
I think this is ready to be reviewed. |
|
Reviewed, merged, ready for a new minor |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new transfomer called
uwswhich is the successor oflws.