This repository has been archived by the owner on Jun 12, 2024. It is now read-only.
Rank effort to review a given PR #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
prince-chrismc
commented
Jan 27, 2023
prince-chrismc
commented
- test visual markdown
prince-chrismc
commented
Jan 27, 2023
| } | ||
|
|
||
| return change, resp, nil | ||
| //if len(files) <= 2 && addition <= 10 && deletions == 0 { | ||
| if len(files) <= 2 && (addition+deletions) <= 10 { |
There was a problem hiding this comment.
I'd love some feedback 🙏
There was a problem hiding this comment.
The numbers seem ok for me. I worry that it will not be until we actually try these numbers that we'll know if they are balanced properly, but my gut says yes :)
There was a problem hiding this comment.
There a nice example, #109 (comment)
Reasonable is all I need on a first pass ;) I picked a few PRs while reviewing and said that seems about right 😆
There was a problem hiding this comment.
As first step I think is okay. We can update in case you feel different in the future.
Codecov Report
@@ Coverage Diff @@
## main #109 +/- ##
==========================================
+ Coverage 40.81% 44.15% +3.33%
==========================================
Files 15 15
Lines 566 607 +41
==========================================
+ Hits 231 268 +37
+ Misses 321 316 -5
- Partials 14 23 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
✨ Summary of Pull Requests Pending Review!☑️ Selection Criteria:
Legend
🤓 Please Review!There are 85 pull requests currently under way 🕵️
✔️ Ready to MergeCurrently 2 pull requests are waiting to be merged 🎉
📋 Statistics
[Raw JSON data](https://raw.githubusercontent.com/prince-chrismc/conan-center-index-pending-review/raw-data/pend |
AbrilRBS
approved these changes
Jan 29, 2023
| } | ||
|
|
||
| return change, resp, nil | ||
| //if len(files) <= 2 && addition <= 10 && deletions == 0 { | ||
| if len(files) <= 2 && (addition+deletions) <= 10 { |
There was a problem hiding this comment.
The numbers seem ok for me. I worry that it will not be until we actually try these numbers that we'll know if they are balanced properly, but my gut says yes :)
🤓 Please Review!There are 100 pull requests currently under way 🕵️
|
|
Very good improvement! Do you think it could be possible to use a more visual ui, for examples squares like github ? |
|
Yeah I don't like the way it looks either both of those are good suggestions! If you could make markdown suggestions that would be a huge help 🙏 |
Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
prince-chrismc
commented
Feb 1, 2023
prince-chrismc
commented
Feb 1, 2023
🤓 Please Review!There are 53 pull requests currently under way 🕵️
✔️ Ready to MergeCurrently 37 pull requests are waiting to be merged 🎉 |
Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
|
Thanks eric for the suggestions, this looks much better. I changed the focus with emojis to small ones instead of big ones... I prefer that seeing it with the t-shirt sizes 👍 |
ericLemanissier
approved these changes
Feb 2, 2023
🤓 Please Review!There are 75 pull requests currently under way 🕵️
✔️ Ready to MergeCurrently 7 pull requests are waiting to be merged 🎉 |
|
Thanks everyone!!! ❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.