Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve front-end test coverage + reduce bundle size #78

Merged
merged 18 commits into from
Feb 6, 2021

Conversation

prince-chrismc
Copy link
Owner

No description provided.

@prince-chrismc prince-chrismc added the front-end This issue or pull request pertains to the front-end component label Feb 4, 2021
@prince-chrismc prince-chrismc added this to the 1.0.0-dev.1 milestone Feb 4, 2021
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #78 (fea768e) into master (49c780d) will increase coverage by 15.90%.
The diff coverage is 94.73%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #78       +/-   ##
===========================================
+ Coverage   74.35%   90.26%   +15.90%     
===========================================
  Files          15       16        +1     
  Lines         117      113        -4     
===========================================
+ Hits           87      102       +15     
+ Misses         30       11       -19     
Impacted Files Coverage Δ
web-app/src/components/App.js 0.00% <ø> (ø)
web-app/src/components/Layout.js 100.00% <ø> (+100.00%) ⬆️
web-app/src/components/cards/Add.js 100.00% <ø> (+100.00%) ⬆️
web-app/src/components/cards/Loading.js 100.00% <ø> (+100.00%) ⬆️
web-app/src/components/dialogs/ConfirmForm.js 100.00% <ø> (ø)
web-app/src/components/dialogs/EditForm.js 100.00% <ø> (ø)
web-app/src/components/dialogs/UserModal.js 100.00% <ø> (ø)
web-app/src/components/operations/Add.js 100.00% <ø> (ø)
web-app/src/components/operations/Delete.js 100.00% <ø> (ø)
web-app/src/components/operations/Edit.js 100.00% <ø> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49c780d...fea768e. Read the comment docs.

@prince-chrismc
Copy link
Owner Author

WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
This can impact web performance.
Assets: 
  static/app.e64ec2a26c6e26a27506.js (1010 KiB)
  static/vendor.e64ec2a26c6e26a27506.js (424 KiB)

WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance.
Entrypoints:
  app (1.4 MiB)
      static/vendor.e64ec2a26c6e26a27506.js
      styles/styles.e64ec2a26c6e26a27506.css
      static/styles.e64ec2a26c6e26a27506.js
      static/app.e64ec2a26c6e26a27506.js

@prince-chrismc
Copy link
Owner Author

static/app.0a88a8d999c55c163a50.js 112 KiB 3 [emitted] [immutable] app

WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
This can impact web performance.
Assets:
  static/vendor.0a88a8d999c55c163a50.js (405 KiB)

WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance.
Entrypoints:
  app (517 KiB)
      static/vendor.0a88a8d999c55c163a50.js
      styles/styles.0a88a8d999c55c163a50.css
      static/styles.0a88a8d999c55c163a50.js
      static/app.0a88a8d999c55c163a50.js

@prince-chrismc
Copy link
Owner Author

prince-chrismc commented Feb 5, 2021

princechrismc.jfrog.io/user-management-docker/user-management:1.0.0-commit.260

Is currently failing locally the MakeCards in not being loaded correct + react error 🤷

FIXED: 08a4763

@prince-chrismc prince-chrismc merged commit 8c79980 into master Feb 6, 2021
@prince-chrismc prince-chrismc deleted the improve-fe-coverage-bundle-size branch February 6, 2021 02:00
@prince-chrismc prince-chrismc mentioned this pull request Feb 6, 2021
11 tasks
@prince-chrismc prince-chrismc added the deployment This issue or pull request pertains to the means by which the application is published label Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment This issue or pull request pertains to the means by which the application is published front-end This issue or pull request pertains to the front-end component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant