Fix: Do not request job control in bash #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #331 It's unlikely that job control was ever granted. Currently we're getting ERROR Unexpected container setup output: /bin/bash: cannot set terminal process group (-1): Inappropriate ioctl for device /bin/bash: no job control in this shell Because of this.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #345 +/- ##
==========================================
- Coverage 76.09% 76.02% -0.07%
==========================================
Files 18 18
Lines 2878 2878
==========================================
- Hits 2190 2188 -2
- Misses 688 690 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #331
It's unlikely that job control was ever granted. Currently we're getting
ERROR Unexpected container setup output: /bin/bash: cannot set terminal process group (-1): Inappropriate ioctl for device
/bin/bash: no job control in this shell
Because of this.