Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Adding an indication for mandatory fields in the add/edit transaction form #30

Closed
pssruthy opened this issue Oct 18, 2022 · 3 comments
Closed

[Enhancement] Adding an indication for mandatory fields in the add/edit transaction form #30

pssruthy opened this issue Oct 18, 2022 · 3 comments
Assignees
@pssruthy
Labels
enhancement New feature or request hacktoberfest-accepted

Comments

@pssruthy
Copy link
Contributor

When the user try to add/ edit a new transaction with a few fields being empty like below, user will be getting a validation error to fill the mandatory fields. It would be better if we could add an indicator like * to represent mandatory fields.

Screenshot 2022-10-18 at 9 54 19 PM

Screenshot 2022-10-18 at 9 54 26 PM
@pssruthy
Copy link
Contributor Author

pssruthy commented Oct 18, 2022 •
edited
Loading

@princid could you review this suggestion and add the required labels?
I would like to work on this.

Expected result

Screenshot 2022-10-18 at 10 25 27 PM

@princid
Copy link
Owner

princid commented Oct 21, 2022

@pssruthy Sure! Go ahead.

pssruthy added a commit to pssruthy/Expense-Tracker that referenced this issue Oct 21, 2022
@pssruthy
[ princid#30 ] Add indicator and error message for mandatory fields i…
f9cfa15 
…n transaction form
@pssruthy pssruthy mentioned this issue Oct 21, 2022
Merged
@pssruthy
Copy link
Contributor Author

@princid I have raised a PR. Please review and merge it.

princid added a commit that referenced this issue Oct 22, 2022
@princid
Merge pull request #32 from pssruthy/mandatory-field-indicator
373c243 
[ #30 ] Add indicator and error message for mandatory fields in transaction form
princid added a commit that referenced this issue Oct 22, 2022
@princid
Revert "[ #30 ] Add indicator and error message for mandatory fields …
49770f5 
…in transaction form"
princid added a commit that referenced this issue Oct 22, 2022
@princid
Merge pull request #34 from princid/revert-32-mandatory-field-indicator
00b4dd4 
Revert "[ #30 ] Add indicator and error message for mandatory fields …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pssruthy pssruthy

Labels
enhancement New feature or request hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pssruthy @princid