Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improve coverage measurement #96

Merged
merged 1 commit into from
Jun 11, 2023
Merged

ci: improve coverage measurement #96

merged 1 commit into from
Jun 11, 2023

Conversation

princjef
Copy link
Owner

The current coverage measurement only tracks intra-package coverage, which is very impractical for something that is best verified through snapshot testing. This changes that pattern to encourage more full system tests

@codecov-commenter
Copy link

Codecov Report

Merging #96 (499cdb1) into master (5e37559) will increase coverage by 16.27%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master      #96       +/-   ##
===========================================
+ Coverage   58.26%   74.54%   +16.27%     
===========================================
  Files          20       22        +2     
  Lines        1826     1960      +134     
===========================================
+ Hits         1064     1461      +397     
+ Misses        677      398      -279     
- Partials       85      101       +16     

see 16 files with indirect coverage changes

@princjef princjef merged commit 43f2be8 into master Jun 11, 2023
5 checks passed
@princjef princjef deleted the better-coverage branch June 11, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants