Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ¥ symbol for JPY #268

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Support ¥ symbol for JPY #268

merged 1 commit into from
Feb 23, 2024

Conversation

frectonz
Copy link
Contributor

@frectonz frectonz commented Feb 15, 2024

I implemented JPY as a currency symbol

BEFORE
image

AFTER
image

I also want to implement other currency symbols in this PR. I just couldn't decide to implement them in multiple PRs or all in one. The following is the list of currency i have in my mind.

  • Yen Symbol – ¥
  • Franc Symbol – ₣
  • Rupee Symbol – ₹
  • Dinar Symbol – د.ك
  • Dirham Symbol – د.إ
  • Riyal Symbol – ﷼‎
  • Mark Symbol – ₻
  • Ruouble Symbol – ₽
  • Lari Symbol - ₾
  • Lira Symbol - ₺
  • Manat Symbol – ₼
  • Tenge Symbol – ₸
  • Hryvnia Symbol – ₴
  • Spesmilo Symbol – ₷
  • Baht Symbol - ฿
  • Won Symbol – 원
  • Dong Symbol – ₫
  • Tugrik Symbol – ₮
  • Drachma Symbol – ₯
  • Peso Symbol – ₱
  • Austral Symbol – ₳
  • Cedi Symbol – ₵
  • Guarani Symbol – ₲
  • Sheqel Symbol – ₪
  • Penny Symbol – ₰

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fb02762) 83.20% compared to head (dc78e37) 83.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #268   +/-   ##
=======================================
  Coverage   83.20%   83.20%           
=======================================
  Files          52       52           
  Lines       14532    14538    +6     
=======================================
+ Hits        12091    12097    +6     
  Misses       2441     2441           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@printfn printfn merged commit b042ecb into printfn:main Feb 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants