Skip to content
This repository has been archived by the owner on Jan 24, 2018. It is now read-only.

Only parse href's with a certain class #18

Closed
somebeaver opened this issue Oct 8, 2013 · 2 comments
Closed

Only parse href's with a certain class #18

somebeaver opened this issue Oct 8, 2013 · 2 comments

Comments

@somebeaver
Copy link

On a site I'm currently working on, I use skrollr and skrollr-menu. I also use a tab system that's based on anchor links.

Since skrollr-menu will do its thing to every anchor link on a page, my tab system will now smooth scroll when not intended.

It would be useful to have an option in skrollr-menu that allows you to define a menu class, so that only <a> elements with that class will be used for smooth scrolling by skrollr-menu

(I am not sure how to add the "feature request" tag, first time using GitHub commenting).

@Prinzhorn
Copy link
Owner

Try calling stopPropagation in your tabbing code. It will prevent the event from bubbling to the document, where skrollr-menu listens for it.

(I am not sure how to add the "feature request" tag, first time using GitHub commenting).

Tags can only be used by repo maintainers to organize issues.

@somebeaver
Copy link
Author

Thank you for the stopPropagation suggestion, it solved the problem. Really appreciate the work you put into skrollr and skrollr-menu!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants