Shiny improvements #10
Conversation
Renamed read_PRISMAdata() to PRISMA_data(), deprecated read_PRISMAdata() Renamed sr_flow_interactive() to PRISMA_interactive_(), moved to utils.R prefixed utils functions with PRISMA_ (renamed insertJS_ to insert_js_) Added ORCID and email to contributor page
chriscpritchard
force-pushed
the
shiny-update
branch
from
dbbfd84
to
e229b89
Compare
Remove functions.R Add option in PRISMA_flowchart() to not show blue side labels
chriscpritchard
force-pushed
the
shiny-update
branch
from
e229b89
to
0be1ed7
Compare
|
Tested this @nealhaddaway @mcguinlu works fine with the changes Neal made on the master branch so should be good to go and this can be released / deployed as V0.0.2 as it includes #7. I haven't tested on shinyapps.io as I don't have an account, but according to their website they support devtools::install_github() so it should just pull the latest version from here! |
|
Great - thanks, Chris! And should I merge both PRs, or do one at a time...? |
|
Just this one would be best as it includes the other one
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: nealhaddaway ***@***.***>
Sent: Wednesday, July 7, 2021 6:50:39 AM
To: nealhaddaway/PRISMA2020 ***@***.***>
Cc: Chris Pritchard ***@***.***>; Author ***@***.***>
Subject: Re: [nealhaddaway/PRISMA2020] Shiny improvements (#10)
Great - thanks, Chris! And should I merge both PRs, or do one at a time...?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#10 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAOA7YSOFCOK5QGCOAHV4I3TWPTK7ANCNFSM46JER53A>.
|
|
Great - I've done that now |
|
Hmm - it seems to have lost my code for removing blank lines in the sources boxes... But it's not super important... |
|
THat's really annoying, give me a few minutes I'll try and see where that happened (might have been in the rejiggering of functions and I missed it when merging). |
|
Yup I've found the issue, I think it was only updated in the shiny code so I missed it... |
|
Ah cool - what's the best thing to do? |
|
I'll fix it check it works and make a PR |
|
Sweet - thank you!!
…________________________________
From: Chris Pritchard ***@***.***>
Sent: 07 July 2021 06:47
To: nealhaddaway/PRISMA2020 ***@***.***>
Cc: nealhaddaway ***@***.***>; State change ***@***.***>
Subject: Re: [nealhaddaway/PRISMA2020] Shiny improvements (#10)
I'll fix it check it works and make a PR
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub<#10 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKOBNXDJBDNK5EVSHKK3UO3TWP2AZANCNFSM46JER53A>.
|
|
Done, PR #12 fixes this, sorry I missed it. I've taken your code from the shiny function and added it to the main one |
This PR is for shiny improvements. Currently in a draft state as further improvements needed - this branch is based off the standard-functions branch, so #7 would ideally need to be merged before this.
Closes #6
Closes #9