Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat package.json as project root #1012

Closed
jasonkuhrt opened this issue Jun 10, 2020 · 0 comments · Fixed by #1034
Closed

Treat package.json as project root #1012

jasonkuhrt opened this issue Jun 10, 2020 · 0 comments · Fixed by #1034
Labels
lang/js Related to JavaScript language interop scope/layout type/feat Add a new capability or enhance an existing one

Comments

@jasonkuhrt
Copy link
Member

Perceived Problem

  • Sometimes user does not have tsconfig.json at what they consider to be their project root Tutorial is hard to follow #999
  • Nexus considers location of tsconfig.json to be the project root
  • JavaScript does not have concept of tsconfig.json Support JS #85

Ideas / Proposed Solution(s)

  • Make Nexus consider project root to be the first found package.json
@jasonkuhrt jasonkuhrt added type/feat Add a new capability or enhance an existing one scope/layout labels Jun 10, 2020
@jasonkuhrt jasonkuhrt added this to This Sprint in Prisma GraphQL WG Team Jun 11, 2020
@jasonkuhrt jasonkuhrt added the lang/js Related to JavaScript language interop label Jun 11, 2020
This was referenced Jun 12, 2020
Merged
Merged
Prisma GraphQL WG Team automation moved this from This Sprint to Shipped Jun 12, 2020
jasonkuhrt pushed a commit that referenced this issue Jun 12, 2020
feat: treat fist package.json as project root (#1034)
19bb322 
closes #1012

BREAKING CHANGE:

When invoking the CLI within a Nexus project, it will use the location of the package.json as its project root rather than blindly use the real CWD. Mostly this should just fix things but some users might have learnt the previous behaviour.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lang/js Related to JavaScript language interop scope/layout type/feat Add a new capability or enhance an existing one
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: treat fist package.json as project root prisma-labs/graphql-framework-experiment
1 participant
@jasonkuhrt