feat(server): add serverless handlers #788
Conversation
jasonkuhrt
changed the title
|
|
| "dotenv": "^8.2.0", | ||
| "express": "^4.17.1", | ||
| "express-graphql": "^0.9.0", | ||
| "fp-ts": "^2.5.4", |
There was a problem hiding this comment.
I'm not convinced by the need of something as fancy as fp-ts yet. As a first step, we could've just created our own internal either type, or either-like type. While I see great patterns that we could achieve with fp-ts, we need to make sure that its types don't ever land on the public API, because even something as popular as the Either type in the fp world is not common at all in the JS world
There was a problem hiding this comment.
Yeah we’ll definitely not want the FP API/types escaping the implementation. It might mean we need to eventually maintain a thin layer on top. Really whatever helps us the most... the type safety added by not having untyped throw is great for us internally for example. Add more and more benefits like this and I could see reaching a point where net velocity/simplicity for us is had by adopting the fp implementation with a thin non-FP layer.
Internally I think it’s worth using the gold standard lib to properly appraise the techniques. It’s not like we’re adding many mb or kb to the nexus package. And the path forward to more FP features that rigorously compose is available when we’re ready. Like rx and lodash it is free shakable so once we care we can look into that.
src/runtime/app.ts
Outdated
| assemble() { | ||
| if (appState.assembled) return | ||
|
|
||
| appState.assembled = true | ||
| appState.assembled = {} as any |
There was a problem hiding this comment.
Couldn't you use a Partial here?
There was a problem hiding this comment.
Leaving a todo for now
Think the settings readonly is causing issue. Tried Mutable modifier from type fest (also related: microsoft/TypeScript#24509) on the assembled app state settings type, but didn't seem to help.
src/runtime/schema/schema.ts
Outdated
| // schema: null, | ||
| // missingTypes: null, |
There was a problem hiding this comment.
Can we remove the comments or are they supposed to come back later?
| @@ -117,7 +119,8 @@ export function create(): App { | |||
| assemble() { | |||
| if (appState.assembled) return | |||
|
|
|||
| appState.assembled = {} as any | |||
| // todo https://github.com/graphql-nexus/nexus/pull/788#discussion_r420645846 | |||
| appState.assembled = {} as Partial<AppState['assembled']> | |||
There was a problem hiding this comment.
This tweak made all tests failed
There was a problem hiding this comment.
Yeah this wasn't supposed to get through :(
progresses #782
closes #528
Implementation Notes
Several deps have been added in this PR. The goal is to move quickly and iterate on our server components. None of the deps are large, even fp-ts.
fp-ts is exciting. It begins our journey into throw-free code!
User Notes
This feature will remain undocumented while we make progress on more parts around it.
This feature exposes request handlers on the server component.
Users can use these to response to requests in a serverless environment.
TODO