Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension support: Regenerate files and include in graphql config #234

Merged
merged 2 commits into from Jun 11, 2018
Merged

Extension support: Regenerate files and include in graphql config #234

merged 2 commits into from Jun 11, 2018

Conversation

divyenduz
Copy link
Contributor

@divyenduz divyenduz commented Jun 11, 2018

  1. Add includes in graphql config to support extension
  2. Regenerate prisma.graphql via codegen get-schema
  3. Regenerate prisma.ts via codegen codegen
  4. Add missing deps graphql, prisma-binding

@divyenduz divyenduz changed the title Regenerate files and include in graphql config Extension support: Regenerate files and include in graphql config Jun 11, 2018
@@ -10,10 +10,11 @@
},
"dependencies": {
"bcryptjs": "2.4.3",
"graphql": "^0.13.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

graphql codegen fails if there is no graphql

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to provide graphql-cli instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope! graphql codegen command fails with Error: Cannot find module 'graphql' if graphql package is not installed.

@marktani marktani merged commit 626ac64 into prisma-labs:master Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants