feat!: accept DocumentNode input #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #176 Example: ```ts import gql from 'graphql-tag' await request('https://foo.bar/graphql', gql`...`) ``` If you don't actually care about using DocumentNode but just want the tooling support for gql template tag like IDE syntax coloring and prettier autoformat then note you can use the passthrough gql tag shipped with graphql-request to save a bit of performance and not have to install another dep into your project. ```ts import { gql } from 'graphql-request' await request('https://foo.bar/graphql', gql`...`) ```
jasonkuhrt
commented
Aug 3, 2020
jasonkuhrt
changed the title
techeng322
pushed a commit
to techeng322/GraphQL-Request
that referenced
this pull request
Nov 12, 2023
closes #176
Example:
```ts
import gql from 'graphql-tag'
await request('https://foo.bar/graphql', gql`...`)
```
If you don't actually care about using DocumentNode but just
want the tooling support for gql template tag like IDE syntax
coloring and prettier autoformat then note you can use the
passthrough gql tag shipped with graphql-request to save a bit
of performance and not have to install another dep into your project.
```ts
import { gql } from 'graphql-request'
await request('https://foo.bar/graphql', gql`...`)
```
BREAKING CHANGE:
`graphql-request` now requires `graphql` version 14.x or 15.x as a peer dependency.
`graphql-request` uses a TypeScript type from the `graphql` package such that if you are using TypeScript to build your project and you are using `graphql-request` but don't have `graphql` installed TypeScript build will fail. Details [here](jasonkuhrt/graphql-request#183 (comment)). If you are a JS user then you do not technically need to install `graphql`. However if you use an IDE that picks up TS types even for JS (like VSCode) then its still in your interest to install `graphql` so that you can benefit from enhanced type safety during development.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #176
Example:
If you don't actually care about using DocumentNode but just
want the tooling support for gql template tag like IDE syntax
coloring and prettier autoformat then note you can use the
passthrough gql tag shipped with graphql-request to save a bit
of performance and not have to install another dep into your project.
BREAKING CHANGE:
graphql-requestnow requiresgraphqlversion 14.x or 15.x as a peer dependency.graphql-requestuses a TypeScript type from thegraphqlpackage such that if you are using TypeScript to build your project and you are usinggraphql-requestbut don't havegraphqlinstalled TypeScript build will fail. Details here. If you are a JS user then you do not technically need to installgraphql. However if you use an IDE that picks up TS types even for JS (like VSCode) then its still in your interest to installgraphqlso that you can benefit from enhanced type safety during development.