perf(core): do not deeply resolve an input type more than once (#373)

Relates to #310
prisma-labs · Jan 1, 2019 · ae1b596 · ae1b596
1 parent bd44b33
commit ae1b596
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/packages/graphqlgen/src/generators/common.spec.ts b/packages/graphqlgen/src/generators/common.spec.ts
@@ -141,7 +141,6 @@ Array [
   "B",
   "D",
   "C",
-  "D",
 ]
 `)
 })
diff --git a/packages/graphqlgen/src/generators/common.ts b/packages/graphqlgen/src/generators/common.ts
@@ -239,9 +239,18 @@ export function deepResolveInputTypes(
     const childTypes = type.fields
       .filter(t => t.type.isInput && !seen[t.type.name])
       .map(t => t.type.name)
-      .map(name =>
-        deepResolveInputTypes(inputTypesMap, name, { ...seen, [name]: true }),
-      )
+      .map(name => {
+        /**
+         * Mutate so that we track state across tree branches.
+         *
+         * Example, only visit "C" once:
+         *     A
+         *     ├── B ── C
+         *     └── D ── C
+         */
+        seen[name] = true
+        return deepResolveInputTypes(inputTypesMap, name, seen)
+      })
       .reduce(concat, [])
     return [typeName, ...childTypes]
   } else {