Allow undefined for nullable graphql types

[kinolaev]

Related issues:
#278
prisma/prisma#3621

[MathiasKandelborg]

I've just encountered this issue, after beginning to write new resolvers with graphqlgen. It would be great to see this merged! Can I find information on a roadmap or something of the likes to make sure I update as soon as possible?

[jasonkuhrt]

@MathiasKandelborg maybe for now try Github's new "watch releases only" feature

[timsuchanek]

@kinolaev thanks a lot for the PR! Could you please update it to resolve the conflicts?

[kinolaev]

Hello @timsuchanek!
Conflicts resolved.

[jasonkuhrt]

Thanks @kinolaev, exciting to see this getting near the finish line!

[jasonkuhrt]

Hey @kinolaev anything I can do to help? Would you mind if I jumped on the remaining TODOs here?

[jasonkuhrt]

@timsuchanek thanks to our new compile check test step I discovered that, after rebasing, | undefined is valid in TypeScript but not FlowType. It felt good to have that payoff!

[jasonkuhrt]

Almost there, but I just remembered that instead of:

  export interface ArgsPictures {
    first: number | null | undefined
  }

We want:

  export interface ArgsPictures {
    first?: number | null
  }

Not sure how I'll do that per-se as current rendering functions only deal with type rendering in the value area, not the key area. Hopefully won't be too painful :)

[jasonkuhrt]

Alright, I think this is ready 🚢

Thanks @kinolaev for originally kicking off this PR!