-
Notifications
You must be signed in to change notification settings - Fork 56
Allow undefined for nullable graphql types #331
Conversation
I've just encountered this issue, after beginning to write new resolvers with graphqlgen. It would be great to see this merged! Can I find information on a roadmap or something of the likes to make sure I update as soon as possible? |
@MathiasKandelborg maybe for now try Github's new "watch releases only" feature |
@kinolaev thanks a lot for the PR! Could you please update it to resolve the conflicts? |
d637194
to
f7c9fe2
Compare
Hello @timsuchanek! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kinolaev, exciting to see this getting near the finish line!
packages/graphqlgen/src/tests/typescript/__snapshots__/basic.test.ts.snap
Outdated
Show resolved
Hide resolved
Hey @kinolaev anything I can do to help? Would you mind if I jumped on the remaining TODOs here? |
@timsuchanek thanks to our new compile check test step I discovered that, after rebasing, |
Almost there, but I just remembered that instead of: export interface ArgsPictures {
first: number | null | undefined
} We want: export interface ArgsPictures {
first?: number | null
} Not sure how I'll do that per-se as current rendering functions only deal with type rendering in the value area, not the key area. Hopefully won't be too painful :) |
Alright, I think this is ready 🚢 Thanks @kinolaev for originally kicking off this PR! |
Related issues:
#278
prisma/prisma#3621