Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison tables #338

Merged
merged 14 commits into from May 27, 2020
Merged

Comparison tables #338

merged 14 commits into from May 27, 2020

Conversation

mhwelander
Copy link
Contributor

No description provided.

@mhwelander mhwelander self-assigned this May 12, 2020
@mhwelander mhwelander requested a review from 2color May 12, 2020 13:12
Copy link
Member

@nikolasburk nikolasburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great start @mhwelander 🚀

I've found a few issues already:

  • lots of code blocks seems to have extra indentation
  • I believe the MDX code block component is called CodeBlock, does Code also work?

For some reason, I can't expand the API comparisons item in the preview, so I don't see what the rendered version of this page looks like right now...

Copy link
Contributor

@2color 2color left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really useful and will help developers coming from either one of Sequelize, TypeORM, or Mongoose 🎉

Other ideas:

  • What do you think about adding a line about Prisma not being an API and link to why Prisma is not an ORM?

I haven't gone through the TypeORM comparison but it's not a blocker

@mhwelander
Copy link
Contributor Author

  • Added a sentence about Prisma being a toolkit & link to 'not an ORM'
  • Code block tab issue is a Netlify thing
  • Removed 'raw SQL' reference from the Mongo ODM! Changed it to: run query, then filter

@mhwelander mhwelander merged commit bbd5345 into master May 27, 2020
@mhwelander mhwelander deleted the comparison-tables branch May 27, 2020 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants