Add documentation for MariaDB users #5706
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ottok is attempting to deploy a commit to the Prisma Team on Vercel. A member of the Team first needs to authorize it. |
janpio
requested changes
Mar 11, 2024
|
Hi!
Thanks for reply. If you don't want a new page, can you share if you can
accept the other commits in this PR so I can prepare them for merge?
|
ottok
force-pushed
the
mariadb-basic-doc
branch
from
795465f
to
3331530
Compare
Merged
Copy the MySQL doc without any changes so that git can be properly used to track the history of the file (e.g. `git log --follow` and `git blame -C -C -C`) and also to make sure the next commits will clearly show how the MariaDB doc deviates from the MySQL doc.
The existing page about MySQL does not mention MariaDB at all, and thus it is unclear to users of MariaDB if Prisma properly supports MariaDB or not. With a new MariaDB-specific page it is easy for users to find that Prisma does indeed support MariaDB, and even has MariaDB in the CI for Prisma. Creating two separate pages for MySQL and MariaDB is useful as future versions of MySQL 8.4 and MariaDB 11.5 are likely to start diverging and thus Prisma users need to have separate pages that give them instructions that are guaranteed to work specifically with the database they use.
ottok
force-pushed
the
mariadb-basic-doc
branch
from
3331530
to
4c8cab8
Compare
|
Closing this as #5713 was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe this PR
I have never used Prisma before, and it took me quite a lot of extra effort to figure out if Prisma supports MariaDB at all because the documentation was only mentioning MySQL. After some digging, I found that indeed Prisma uses both https://www.npmjs.com/package/mariadb for the connector and https://hub.docker.com/_/mariadb as part of the CI, and MariaDB support is actually excellent.
Sequalize has very clear MariaDB documentation, and if you merge this PR then Prisma will be on-par.
Changes
Each commit is atomic and carefully documented - please review this PR by looking commit-by-commit looking at the message and the change at the same time.
Looking at git log in 500-databases and e.g. 4358a41 seems you prefer to squash when merging. Please merge this PR as-is without squashing to avoid loosing the per-commit documentation.
I am also happy to iterate on the contents of this PR based on your feedback. I am also happy to rebase frequently.