Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Test 32bit Node on Windows #1830

Draft
wants to merge 13 commits into
base: dev
Choose a base branch
from
2 changes: 1 addition & 1 deletion .github/scripts/print-version.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ packageJSONDir="$1"
echo "-------------------------"
echo ""

echo "node: $(node -v)"
echo "node: $(node -v) ($(node -p process.arch))"
echo "npm: $(npm -v)"

echo "prisma-version.txt: $(cat .github/prisma-version.txt)"
Expand Down
27 changes: 23 additions & 4 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,25 @@ jobs:
- 19
- 20
clientEngine: ['library', 'binary']
os: [ubuntu-20.04] #, windows-latest, macos-latest]
architecture: [x64]
os: [ubuntu-latest] #, windows-latest, macos-latest]
include: # include additional combinations for explicit x64 (64 bit Node) and x86 (32 bit Node) on Windows
- node: 14
clientEngine: library
architecture: x86
os: windows-latest
- node: 14
clientEngine: binary
architecture: x86
os: windows-latest
- node: 14
clientEngine: library
architecture: x64
os: windows-latest
- node: 14
clientEngine: binary
architecture: x64
os: windows-latest
runs-on: ${{ matrix.os }}

steps:
Expand All @@ -592,6 +610,7 @@ jobs:
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}
architecture: ${{ matrix.architecture }}
cache: 'pnpm'
cache-dependency-path: generic/basic/pnpm-lock.yaml

Expand All @@ -606,17 +625,17 @@ jobs:
replaced=${string/$search/$replace}
echo "DATABASE_URL=$replaced" >> $GITHUB_ENV

- name: test on node ${{ matrix.node }} - ${{ matrix.clientEngine }}
- name: test on node ${{ matrix.node }} (${{ matrix.architecture }}) - ${{matrix.clientEngine}}
id: run-test
uses: nick-invision/retry@v2
with:
timeout_minutes: 10
max_attempts: 3
command: bash .github/scripts/test-project.sh generic basic "node ${{ matrix.node }}"
command: bash .github/scripts/test-project.sh generic basic "node ${{ matrix.node-version }} (${{ matrix.architecture }})"

- name: notify-slack
if: failure()
run: bash .github/slack/notify-failure.sh generic basic "node ${{ matrix.node }}"
run: bash .github/slack/notify-failure.sh generic basic "node ${{ matrix.node-version }} (${{ matrix.architecture }})"

binaries:
needs: [detect_jobs_to_run]
Expand Down