test: add migrate db seed test #2048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on #1807
|
I think we should remove the enginetype from the matrix here, it doesn鈥檛 bring any value I can see (it's tested in other tests and that would reduce the number of jobs here) |
millsp
approved these changes
Sep 3, 2021
janpio
reviewed
Sep 3, 2021
janpio
reviewed
Sep 3, 2021
janpio
reviewed
Sep 3, 2021
|
|
||
| set -eux | ||
|
|
||
| yarn prisma db pull --print |
There was a problem hiding this comment.
confirmation that db push worked?
There was a problem hiding this comment.
It's a copy paste from your script, so probably
janpio
reviewed
Sep 3, 2021
|
|
||
| # generate not needed, it will be done by db push | ||
| # yarn prisma generate | ||
| yarn prisma db push --force-reset |
There was a problem hiding this comment.
if force-reset does not work for whatever reason, the test would possibly also succeed if the seeding fails, correct?
There was a problem hiding this comment.
Well here it's about preparing the db and I assume test.sh runs after with
#!/bin/sh
set -eux
yarn prisma db pull --print
yarn prisma db seed
yarn test
This should fail
janpio
reviewed
Sep 3, 2021
janpio
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on and replaces #1807
closes #1806
@janpio this adds 12 jobs 馃槰