Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attempt to remove encoding #2857

Merged
merged 1 commit into from Jun 9, 2022
Merged

attempt to remove encoding #2857

merged 1 commit into from Jun 9, 2022

Conversation

millsp
Copy link
Member

@millsp millsp commented Jun 8, 2022

No description provided.

@millsp millsp marked this pull request as ready for review June 8, 2022 21:56
@millsp millsp mentioned this pull request Jun 8, 2022
Closed
janpio
janpio approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less code is better

@Jolg42
Copy link
Member

Jolg42 commented Jun 9, 2022

Looks all 馃煝 !

@Jolg42
Copy link
Member

Jolg42 commented Jun 9, 2022

Note: Just found this warning in bundlers (webpack, library, ubuntu-latest) https://github.com/prisma/ecosystem-tests/runs/6801829310?check_suite_focus=true#step:6:134

WARNING in configuration
The 'mode' option has not been set, webpack will fallback to 'production' for this value.
Set 'mode' option to 'development' or 'production' to enable defaults for each environment.
You can also set it to 'none' to disable any default behavior. Learn more: https://webpack.js.org/configuration/mode/

@Jolg42 Jolg42 added this to the 4.0.x milestone Jun 9, 2022
@millsp millsp merged commit fb6fb07 into dev Jun 9, 2022
@millsp millsp deleted the chore/remove-encoding branch June 9, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janpio janpio janpio approved these changes

@Jolg42 Jolg42 Jolg42 approved these changes

@aqrln aqrln Awaiting requested review from aqrln

@SevInf SevInf Awaiting requested review from SevInf SevInf is a code owner

@danstarns danstarns Awaiting requested review from danstarns

@jkomyno jkomyno Awaiting requested review from jkomyno jkomyno is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@millsp @Jolg42 @janpio