Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autocomplete): @datasourcename #1277

Merged
merged 4 commits into from Nov 7, 2022
Merged

fix(autocomplete): @datasourcename #1277

merged 4 commits into from Nov 7, 2022

Conversation

Druue
Copy link
Contributor

@Druue Druue commented Nov 3, 2022

closes #1223

@Druue Druue added this to the 4.6.0 milestone Nov 3, 2022
@Druue Druue requested a review from Jolg42 November 3, 2022 16:33
@Druue Druue self-assigned this Nov 3, 2022
@github-actions
Copy link

github-actions bot commented Nov 3, 2022 •
edited

🤖 Pull request artifacts

file commit
pr1277-prisma.vsix 66169a9

github-actions bot added a commit that referenced this pull request Nov 3, 2022
@github-actions
Upload pr1277-prisma.vsix (9ebec)
8fd2e26 
Pull request: #1277
Commit: 9ebec5d
@github-actions
Copy link

github-actions bot commented Nov 3, 2022

Try this extension build via GitPod

Jolg42
Jolg42 reviewed Nov 3, 2022
View reviewed changes
Copy link
Member

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

Could you add some test(s) for this?

github-actions bot added a commit that referenced this pull request Nov 3, 2022
@github-actions
Upload pr1277-prisma.vsix (16843)
c49f608 
Pull request: #1277
Commit: 168439c
@Druue
Update: cleaned up getSuggestionForFieldAttribute(...).
66169a9 
Now includes the datasourceName in the immediate suggestion list.
Added tests to validate.
github-actions bot added a commit that referenced this pull request Nov 6, 2022
@github-actions
Upload pr1277-prisma.vsix (66169)
db0aba7 
Pull request: #1277
Commit: 66169a9
Jolg42
Jolg42 approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Screenshot 2022-11-07 at 12 36 32
Screenshot 2022-11-07 at 12 36 23
Screenshot 2022-11-07 at 12 36 17

@Jolg42 Jolg42 merged commit c6ca8e0 into main Nov 7, 2022
@Jolg42 Jolg42 deleted the fix/autocomplete_datasource-name branch November 7, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jolg42 Jolg42 Jolg42 approved these changes

Assignees

@Druue Druue

Labels
None yet
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

Schema autocompletion intellisense don't match custom datasource name
2 participants
@Druue @Jolg42