Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ls): Autocomplete datasource field "extensions" #1303

Merged
merged 1 commit into from Nov 25, 2022
Merged

feat(ls): Autocomplete datasource field "extensions" #1303

merged 1 commit into from Nov 25, 2022

Conversation

Druue
Copy link
Contributor

@Druue Druue commented Nov 25, 2022

WHEN

generator client {
    previewFeatures = ["postgresqlExtensions"]
}

datasource db {
    provider = "postgres(ql)"
    | << "extensions = []"
}

closes #1265

@Druue @Jolg42
Added: autcomplete for the datasource field "extensions".
866f4b5 
When: provider is postgres and extensions preview feature is enabled

Co-authored-by: Joël Galeran <galeran@prisma.io>
@Druue Druue added this to the 4.7.0 milestone Nov 25, 2022
@Druue Druue requested a review from Jolg42 November 25, 2022 15:53
@github-actions
Copy link

🤖 Pull request artifacts

file commit
pr1303-prisma.vsix 866f4b5

github-actions bot added a commit that referenced this pull request Nov 25, 2022
@github-actions
Upload pr1303-prisma.vsix (866f4)
189a1bc 
Pull request: #1303
Commit: 866f4b5
@github-actions
Copy link

Try this extension build via GitPod

Jolg42
Jolg42 approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! One more PR to language-tools ✨

@Jolg42 Jolg42 merged commit 50b01e1 into main Nov 25, 2022
@Jolg42 Jolg42 deleted the feat/ac_datasource-pg_extensions branch November 25, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jolg42 Jolg42 Jolg42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.7.0
2 participants
@Druue @Jolg42