Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): Adds badges, logo and repo explanation to README #136

Merged
merged 8 commits into from
May 25, 2020

Conversation

carmenberndt
Copy link
Contributor

closes #135

Adds badges, logo and repo explanation to README

@carmenberndt carmenberndt added this to the Beta 6 milestone May 12, 2020
@carmenberndt
Copy link
Contributor Author

@divyenduz maybe you can explain the About this repository section a bit better, especially how the repository is set up (and maintained)?

@carmenberndt carmenberndt marked this pull request as draft May 12, 2020 16:09
@carmenberndt
Copy link
Contributor Author

I also added badges for the latest stable version, the number of installs, and the rating on the marketplace. All of these badges include a link to the prisma extension. What do you think about them?

@carmenberndt carmenberndt marked this pull request as ready for review May 12, 2020 16:55
@carmenberndt carmenberndt requested a review from janpio May 12, 2020 16:55
@janpio
Copy link
Member

janpio commented May 12, 2020

I like them, pretty useful.

Readme.md Outdated Show resolved Hide resolved
Copy link

@divyenduz divyenduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readme.md Outdated Show resolved Hide resolved
carmenberndt and others added 2 commits May 18, 2020 11:45
Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>
@carmenberndt
Copy link
Contributor Author

Update: added some more information how and when versions are published

Readme.md Outdated Show resolved Hide resolved
Copy link

@divyenduz divyenduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably some more wording to describe the automation workflow more precisely.

Readme.md Outdated

There is a stable version `prisma` and an unstable version `prisma-dev`. The stable one is published as ["Prisma" in the VSCode Marketplace](https://marketplace.visualstudio.com/items?itemName=Prisma.prisma), the unstable one as ["Prisma Dev"](https://marketplace.visualstudio.com/items?itemName=Prisma.prisma-dev). An automated publish runs every 5 minutes calling the `check-update.sh` script:
- stable channel:
- required versions/values in `package.json` are changed and published

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the beginning of this run, the CI job checks for Prisma stable version and scripts/prisma_version_stable contents to be the same. If they are not the same, it makes the required version changes and proceeds further in the job

Readme.md Outdated
There is a stable version `prisma` and an unstable version `prisma-dev`. The stable one is published as ["Prisma" in the VSCode Marketplace](https://marketplace.visualstudio.com/items?itemName=Prisma.prisma), the unstable one as ["Prisma Dev"](https://marketplace.visualstudio.com/items?itemName=Prisma.prisma-dev). An automated publish runs every 5 minutes calling the `check-update.sh` script:
- stable channel:
- required versions/values in `package.json` are changed and published
- changes are not committed

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scripts/prisma_version_stable is one file that is committed by the stable CI job. That enables the future runs to know if an extension version is already published for a specific Prisma CLI version.

Readme.md Outdated
- required versions/values in `package.json` are changed and published
- changes are not committed
- unstable channel:
- required versions/values in `package.json` are changed and published

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above but the file checked in this case is scripts/prisma_version_unstable

Copy link

@divyenduz divyenduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, the unstable section doesn't mention anymore that it commits the versions in package.json files too.

This internal slack discussion of renaming the unstable channel extension to "insider" probably also affects this PR.

Readme.md Outdated
- required versions/values in `package.json` are changed and published
- changes are committed
There is a stable version `prisma` and an unstable version `prisma-dev`. The stable one is published as ["Prisma" in the VSCode Marketplace](https://marketplace.visualstudio.com/items?itemName=Prisma.prisma), the unstable one as ["Prisma Dev"](https://marketplace.visualstudio.com/items?itemName=Prisma.prisma-dev). An automated publish runs every 5 minutes calling the `check-update.sh` script.
In the beginning of this run, the CI job checks for Prisma stable version and `scripts/prisma_version_stable` contents to be the same. If they are not the same, it makes the required version changes and proceeds further in the job. `scripts/prisma_version_stable` is a file that is committed by the stable CI job. That enables the future runs to know if an extension version is already published for a specific Prisma CLI version. The same workflow is done for Prisma unstable version, where the file checked in that case is `scripts/prisma_version_unstable`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same workflow is done for Prisma unstable version - and in addition it also commits the respective package.json files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About renaming of the unstable version, we might change the readme after that is done, since there will be another PR adjusting the scripts and so on anyway.

Copy link
Member

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "There is a stable ..." paragraph is not very easy to understand, but let's fix that in the near future.

@janpio janpio requested a review from divyenduz May 25, 2020 11:21
@janpio janpio changed the title Update README docs(README): Adds badges, logo and repo explanation to README May 25, 2020
@carmenberndt carmenberndt merged commit 9ff6292 into master May 25, 2020
@carmenberndt carmenberndt deleted the docs_update_readme branch May 25, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add badges and repo explanation to README
3 participants