Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lang-server): Add support for Unsupported #684

Merged
merged 9 commits into from
Jan 29, 2021
Merged

Conversation

sdnts
Copy link
Contributor

@sdnts sdnts commented Jan 29, 2021

No description provided.

@sdnts sdnts self-assigned this Jan 29, 2021
@CLAassistant
Copy link

CLAassistant commented Jan 29, 2021

CLA assistant check
All committers have signed the CLA.

@sdnts sdnts changed the title (lang-server): Add support for Unsupported feat(lang-server): Add support for Unsupported Jan 29, 2021
@sdnts sdnts added this to the 2.16.0 milestone Jan 29, 2021
@Jolg42
Copy link
Member

Jolg42 commented Jan 29, 2021

Looks like tests are failing

@sdnts
Copy link
Contributor Author

sdnts commented Jan 29, 2021

Looks like tests are failing

Yep I'll look at all tests on all branches once I finish everything. They seem to be passing locally, so I'll investigate

@Jolg42 Jolg42 linked an issue Jan 29, 2021 that may be closed by this pull request
@janpio
Copy link
Member

janpio commented Jan 29, 2021

This adds auto completion support for the Unsupported term only, correct?

Copy link
Contributor

@albertoperdomo albertoperdomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two suggestions we should probably merge or iterate on, otherwise good to go.

packages/language-server/src/completion/completions.json Outdated Show resolved Hide resolved
packages/language-server/src/completion/completions.json Outdated Show resolved Hide resolved
packages/language-server/src/completion/completions.json Outdated Show resolved Hide resolved
Jolg42 and others added 4 commits January 29, 2021 17:33
@sdnts
Copy link
Contributor Author

sdnts commented Jan 29, 2021

@janpio yeah, if you click on the little arrow in the autocomplete dropdown you should be able to see it

Alright I'm merging this one then

@sdnts sdnts merged commit 4dda091 into master Jan 29, 2021
@sdnts sdnts deleted the feature/unsupported branch January 29, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Unsupported, dbgenerated() and @@ignore
6 participants