Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Suggest using name on index when creation fails because of length #472

Closed
janpio opened this issue Jun 10, 2020 · 3 comments
Closed

Suggest using name on index when creation fails because of length #472

janpio opened this issue Jun 10, 2020 · 3 comments
Assignees
@tomhoule @do4gr
Labels
kind/improvement An improvement to existing feature and code.
Milestone
2.12.0

Comments

@janpio
Copy link
Member

janpio commented Jun 10, 2020

prisma/docs#434 has the details about the problem. This could possibly be nicely handled by migrate.
@pantharshit00 pantharshit00 added the kind/improvement An improvement to existing feature and code. label Jul 2, 2020
@tomhoule tomhoule added the process/candidate Candidate for next Milestone. label Nov 5, 2020
@tomhoule
Copy link
Contributor

tomhoule commented Nov 5, 2020 •
edited

I think we already truncate the index name to fit within the database limits. Candidating this issue to confirm that we do not crash anymore.

@albertoperdomo albertoperdomo removed the process/candidate Candidate for next Milestone. label Nov 11, 2020
@albertoperdomo albertoperdomo added this to the Release 2.12.0 milestone Nov 11, 2020
@do4gr
Copy link
Member

do4gr commented Nov 17, 2020

First task is to try to reproduce whether we still error.

@do4gr
Copy link
Member

do4gr commented Nov 17, 2020

We do not crash anymore in this case but instead automatically truncate the internal autogenerated name. If the user provides a name in the schema, that one is used instead. So nothing to do here.

@do4gr do4gr closed this as completed Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tomhoule tomhoule

@do4gr do4gr

Labels
kind/improvement An improvement to existing feature and code.
Projects
None yet
Milestone
2.12.0
Development

No branches or pull requests
5 participants
@albertoperdomo @janpio @tomhoule @do4gr @pantharshit00