Skip to content
This repository has been archived by the owner on Jan 14, 2021. It is now read-only.

__internal is ignored #181

Closed
divyenduz opened this issue Aug 9, 2019 · 3 comments
Closed

__internal is ignored #181

divyenduz opened this issue Aug 9, 2019 · 3 comments
Assignees
Labels
bug/2-confirmed We have confirmed that this is a bug. kind/bug A reported bug.
Milestone

Comments

@divyenduz
Copy link

divyenduz commented Aug 9, 2019

Photon has an __internal constructor argument meant to be used by projects like Studio. This is ignored right now (after platforms feature was introduced).

Reproduction: https://github.com/divyenduz/p2_181

To Reproduce

  1. Clone the repo and run yarn
  2. yarn lift save --name init
  3. yarn prisma2 lift up
  4. yarn prisma2 generate
  5. yarn seed

It works and shows inserted data in log. It should not work though because in script.ts we are overriding the binaryPath and provide a linux binary. It should have failed.

@divyenduz divyenduz added bug/2-confirmed We have confirmed that this is a bug. kind/bug A reported bug. labels Aug 9, 2019
@divyenduz
Copy link
Author

divyenduz commented Aug 9, 2019

Labelling this as a bug right now because Studio uses it. Candidate to discuss if this is to be removed in future or changed in a significant way.

@janpio janpio added this to the Preview 7 milestone Aug 9, 2019
@timsuchanek
Copy link
Contributor

Note: Also update the spec when done.

@janpio janpio removed the candidate label Aug 9, 2019
@timsuchanek
Copy link
Contributor

image

__internal works as intended. Please note that in the CLI output, we warn you, that we couldn't find the provided binary path, but resolved to one that we found anyways.
The error message for this use-case could be a bit more clearer, but as this is an internal api that no-one else uses, this is not urgent.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug/2-confirmed We have confirmed that this is a bug. kind/bug A reported bug.
Projects
None yet
Development

No branches or pull requests

3 participants