Fix MySQL SqlSchemaDescriber on MySQL 8 #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: test_each_connector with both versions of MySQL edit: done |
Closed
tomhoule
force-pushed
the
fix-schema-describer-on-mysql-8
branch
4 times, most recently
from
037205a
to
d34f4b5
Compare
|
|
|
Currently blocked on #63 |
tomhoule
force-pushed
the
fix-schema-describer-on-mysql-8
branch
from
d34f4b5
to
61f1410
Compare
tomhoule
changed the title
tomhoule
force-pushed
the
fix-schema-describer-on-mysql-8
branch
2 times, most recently
from
81a6cc7
to
71bf23f
Compare
tomhoule
force-pushed
the
fix-schema-describer-on-mysql-8
branch
3 times, most recently
from
fb99a54
to
5a85e90
Compare
In queries, the column names are case-insensitive, but in the ResultSets we get column names with their original case, which changed in MySQL 8. Someone had the same problem on Stackoverflow: https://stackoverflow.com/questions/54538448/what-are-the-changes-in-mysql-8-result-rowset-case
With the docker.rb fixes.
tomhoule
force-pushed
the
fix-schema-describer-on-mysql-8
branch
7 times, most recently
from
40598bc
to
6f30c8f
Compare
tomhoule
force-pushed
the
fix-schema-describer-on-mysql-8
branch
from
d2dc8b4
to
589aafb
Compare
tomhoule
changed the title
miguelff
pushed a commit
that referenced
this pull request
Apr 20, 2023
Replace f64 as the underlying Real type with Decimal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In queries, the column names are case-insensitive, but in the ResultSets
we get column names with their original case, which changed in MySQL 8.
Someone had the same problem on Stackoverflow:
https://stackoverflow.com/questions/54538448/what-are-the-changes-in-mysql-8-result-rowset-case
This fix works, but it feels like there could be a better, more general solution to that column name case sensitivity issue, what do you think? Maybe making accessing a column by name in a ResultSet in prisma-query case-insensitive.