Skip to content

Commit

Permalink
chore: rename distinctOn preview feature to nativeDistinct
Browse files Browse the repository at this point in the history
  • Loading branch information
janpio committed Dec 4, 2023
1 parent 845c140 commit 252b817
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion psl/builtin-connectors/src/postgres_datamodel_connector.rs
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ const CAPABILITIES: ConnectorCapabilities = enumflags2::make_bitflags!(Connector
InsertReturning |
UpdateReturning |
RowIn |
DistinctOn
NativeDistinct
});

pub struct PostgresDatamodelConnector;
Expand Down
4 changes: 2 additions & 2 deletions psl/psl-core/src/common/preview_features.rs
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ features!(
ConnectOrCreate,
CreateMany,
DataProxy,
DistinctOn,
NativeDistinct,
Deno,
Distinct,
DriverAdapters,
Expand Down Expand Up @@ -83,7 +83,7 @@ features!(
pub const ALL_PREVIEW_FEATURES: FeatureMap = FeatureMap {
active: enumflags2::make_bitflags!(PreviewFeature::{
Deno
| DistinctOn
| NativeDistinct
| DriverAdapters
| FullTextIndex
| FullTextSearch
Expand Down
4 changes: 2 additions & 2 deletions psl/psl-core/src/datamodel_connector/capabilities.rs
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@ capabilities!(
NativeUpsert,
InsertReturning,
UpdateReturning,
RowIn, // Connector supports (a, b) IN (c, d) expression.
DistinctOn // Connector supports DB-level distinct (e.g. postgres)
RowIn, // Connector supports (a, b) IN (c, d) expression.
NativeDistinct // Connector supports DB-level distinct (e.g. postgres)
);

/// Contains all capabilities that the connector is able to serve.
Expand Down
2 changes: 1 addition & 1 deletion psl/psl/tests/config/generators.rs
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ fn nice_error_for_unknown_generator_preview_feature() {
.unwrap_err();

let expectation = expect![[r#"
[1;91merror[0m: [1mThe preview feature "foo" is not known. Expected one of: distinctOn, deno, driverAdapters, fullTextIndex, fullTextSearch, metrics, multiSchema, postgresqlExtensions, tracing, views[0m
[1;91merror[0m: [1mThe preview feature "foo" is not known. Expected one of: deno, driverAdapters, fullTextIndex, fullTextSearch, metrics, multiSchema, nativeDistinct, postgresqlExtensions, tracing, views[0m
--> schema.prisma:3
 | 
 2 |  provider = "prisma-client-js"
Expand Down
4 changes: 2 additions & 2 deletions query-engine/query-structure/src/query_arguments.rs
Original file line number Diff line number Diff line change
Expand Up @@ -86,14 +86,14 @@ impl QueryArguments {
.schema
.configuration
.preview_features()
.contains(PreviewFeature::DistinctOn);
.contains(PreviewFeature::NativeDistinct);

let connector_can_distinct_in_db = self
.model()
.dm
.schema
.connector
.has_capability(ConnectorCapability::DistinctOn);
.has_capability(ConnectorCapability::NativeDistinct);

has_distinct_feature && connector_can_distinct_in_db && self.order_by.is_empty()
}
Expand Down

0 comments on commit 252b817

Please sign in to comment.