Skip to content

Commit

Permalink
qe: Fix Windows build after merging c-abi (#4826)
Browse files Browse the repository at this point in the history
Metrics feature does not really make a lot of sense in that case - all
it does is excluding single property from a struct making our life
harder.
  • Loading branch information
SevInf committed Apr 12, 2024
1 parent 1d60431 commit 3364458
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 11 deletions.
3 changes: 0 additions & 3 deletions libs/query-engine-common/Cargo.toml
Expand Up @@ -3,9 +3,6 @@ name = "query-engine-common"
version = "0.1.0"
edition = "2021"

[features]
metrics = []

[dependencies]
thiserror = "1"
url.workspace = true
Expand Down
1 change: 0 additions & 1 deletion libs/query-engine-common/src/engine.rs
Expand Up @@ -58,7 +58,6 @@ pub struct EngineBuilder {
pub struct ConnectedEngineNative {
pub config_dir: PathBuf,
pub env: HashMap<String, String>,
#[cfg(feature = "metrics")]
pub metrics: Option<query_engine_metrics::MetricRegistry>,
}

Expand Down
3 changes: 0 additions & 3 deletions query-engine/query-engine-c-abi/Cargo.toml
Expand Up @@ -8,9 +8,6 @@ doc = false
crate-type = ["staticlib"]
name = "query_engine"

[features]
metrics = ["query-engine-common/metrics"]

[dependencies]
anyhow = "1"
async-trait = "0.1"
Expand Down
1 change: 0 additions & 1 deletion query-engine/query-engine-c-abi/src/engine.rs
Expand Up @@ -266,7 +266,6 @@ impl QueryEngine {
native: ConnectedEngineNative {
config_dir: builder.native.config_dir.clone(),
env: builder.native.env.clone(),
#[cfg(feature = "metrics")]
metrics: None,
},
}) as Result<ConnectedEngine>
Expand Down
4 changes: 1 addition & 3 deletions query-engine/query-engine-node-api/Cargo.toml
Expand Up @@ -25,9 +25,7 @@ request-handlers = { path = "../request-handlers", features = [
"all",
] }
query-connector = { path = "../connectors/query-connector" }
query-engine-common = { path = "../../libs/query-engine-common", features = [
"metrics",
] }
query-engine-common = { path = "../../libs/query-engine-common" }
user-facing-errors = { path = "../../libs/user-facing-errors" }
psl = { workspace = true, features = ["all"] }
sql-connector = { path = "../connectors/sql-query-connector", package = "sql-query-connector", features = [
Expand Down

0 comments on commit 3364458

Please sign in to comment.