Document Restartable

prisma · Nov 28, 2023 · 9dad3a9 · 9dad3a9
1 parent 601c9e5
commit 9dad3a9
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/query-engine/connector-test-kit-rs/query-tests-setup/Cargo.toml b/query-engine/connector-test-kit-rs/query-tests-setup/Cargo.toml
@@ -33,7 +33,7 @@ indexmap = { version = "1.0", features = ["serde-1"] }
 query-engine-metrics = {path = "../../metrics"}
 quaint.workspace = true
 jsonrpc-core = "17"
-futures = "0.3" 
+futures = "0.3"
 
 # Only this version is vetted, upgrade only after going through the code,
 # as this is a small crate with little user base.

diff --git a/...y-engine/connector-test-kit-rs/query-tests-setup/src/connector_tag/js/external_process.rs b/...y-engine/connector-test-kit-rs/query-tests-setup/src/connector_tag/js/external_process.rs
@@ -97,6 +97,10 @@ impl ExecutorProcess {
     }
 }
 
+/// Wraps an ExecutorProcess allowing for restarting it.
+///
+/// A node process can die for a number of reasons, being one that any `panic!` occurring in Rust
+/// asynchronous code are translated to an abort trap by wasm-bindgen, which kills the node process.
 #[derive(Clone)]
 pub(crate) struct RestartableExecutorProcess {
     p: Arc<Mutex<ExecutorProcess>>,

diff --git a/query-engine/query-engine-wasm/Cargo.toml b/query-engine/query-engine-wasm/Cargo.toml
@@ -6,7 +6,7 @@ edition = "2021"
 [lib]
 doc = false
 crate-type = ["cdylib"]
-name = "query_engine"
+name = "query_engine_wasm"
 
 [dependencies]