Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testdb setup ignores Migrate errors #1834

Closed
do4gr opened this issue Apr 9, 2021 · 1 comment · Fixed by #1864
Closed

Testdb setup ignores Migrate errors #1834

do4gr opened this issue Apr 9, 2021 · 1 comment · Fixed by #1864
Assignees
Labels
kind/bug A reported bug. team/client Issue for team Client. tech/engines/migration engine Issue in the Migration Engine topic: sql server Microsoft SQL Server
Milestone

Comments

@do4gr
Copy link
Member

do4gr commented Apr 9, 2021

This is hiding a bunch of ddl failures on SQLServer tests. Seems they are all related to Cascade problems.

Screen Shot 2021-04-09 at 17 22 26

You can trigger the tests by modifying the testdb setup like below.

 def resetAndSetupDatabase(): Unit = {
    import scala.sys.process._
    val cmd = List(EnvVars.migrationEngineBinaryPath, "cli", "-d", project.fullDatamodelBase64Encoded, "qe-setup")

    cmd.!  // switch this to cmd.!! to make the tests fail upon migrate errors
  }
@pimeys pimeys self-assigned this Apr 9, 2021
@pimeys pimeys added process/candidate topic: sql server Microsoft SQL Server tech/engines/migration engine Issue in the Migration Engine labels Apr 9, 2021
@tomhoule tomhoule added the team/schema Issue for team Schema. label Apr 14, 2021
@tomhoule tomhoule added this to the 2.22.0 milestone Apr 14, 2021
@tomhoule
Copy link
Contributor

Scheduled for this cycle because sql server.

@matthewmueller matthewmueller added the kind/bug A reported bug. label Apr 14, 2021
@tomhoule tomhoule added team/client Issue for team Client. process/candidate and removed process/candidate team/schema Issue for team Schema. labels May 5, 2021
@tomhoule tomhoule removed this from the 2.22.0 milestone May 5, 2021
@matthewmueller matthewmueller added this to the 2.23.0 milestone May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A reported bug. team/client Issue for team Client. tech/engines/migration engine Issue in the Migration Engine topic: sql server Microsoft SQL Server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants