Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore a few silently failing tests for SQL Server #1864

Merged
merged 1 commit into from May 10, 2021

Conversation

pimeys
Copy link
Contributor

@pimeys pimeys commented Apr 19, 2021

  • They all do reference loops
  • They don't work currently
  • All will work when we can do custom onDelete and onUpdate rules

Closes: #1834

- They all do reference loops
- They don't work currently
- All will work when we can do custom `onDelete` and `onUpdate` rules
@pimeys pimeys added this to the 2.22.0 milestone Apr 19, 2021
@pimeys pimeys requested a review from do4gr April 19, 2021 18:18
@pimeys
Copy link
Contributor Author

pimeys commented Apr 19, 2021

Adding that extra ! really breaks everything for me. Is there a way I can validate these @do4gr?

Copy link
Member

@do4gr do4gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Gotta love self-relations.

@pimeys pimeys merged commit 96f8076 into master May 10, 2021
@pimeys pimeys deleted the fix-sql-server-migrate-errors branch May 10, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testdb setup ignores Migrate errors
2 participants