Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DA] Planetscale engine tests: one2m_mix_required_writable_readable #4482

Closed
miguelff opened this issue Nov 21, 2023 · 2 comments
Closed

[DA] Planetscale engine tests: one2m_mix_required_writable_readable #4482

miguelff opened this issue Nov 21, 2023 · 2 comments
Assignees
Labels
topic: driver adapters formerly phase 1
Milestone

Comments

@miguelff
Copy link
Contributor

miguelff commented Nov 21, 2023

This is a subcluster of failures after having enabled planetscale tests in #4423

Failing tests in this cluster:

writes::relations::compound_fks_mixed_requiredness::compound_fks::one2m_mix_required_writable_readable

Please follow this process

@jkomyno
Copy link
Contributor

jkomyno commented Jun 6, 2024

I can confirm that this still fails on both Napi and Wasm, with

Expected result to return an error, but found success: {"data":{"createOnePost":{"id":2,"user_id":2,"user_age":2,"User":null}}}

The reason is that, on PlanetScale, we don't have foreign key violations. We should thus get rid of

  // Foreign key violation
  assert_error!(
      &runner,
      r#"mutation{createOnePost(data:{id: 2, user_id:2, user_age: 2}){id, user_id, user_age, User{id}}}"#,
      2003
  );

for PlanetScale only.

@jkomyno jkomyno self-assigned this Jun 6, 2024
jkomyno added a commit that referenced this issue Jun 7, 2024
* test(query-engine): Fix PlanetScale test, #4482

* test(query-engine): Fix PlanetScale test, #4485
@jkomyno
Copy link
Contributor

jkomyno commented Jun 7, 2024

Fixed via #4909

@jkomyno jkomyno closed this as completed Jun 7, 2024
@janpio janpio added this to the 5.16.0 milestone Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: driver adapters formerly phase 1
Projects
None yet
Development

No branches or pull requests

4 participants