Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Engine: Multi field unique #60

Closed
mavilein opened this issue Sep 25, 2019 · 3 comments
Closed

Query Engine: Multi field unique #60

mavilein opened this issue Sep 25, 2019 · 3 comments
Assignees
Milestone

Comments

@mavilein
Copy link
Member

Check the related epic for an initial breakdown of work packages.

Please use supply a more detailed task list in a comment.

@mavilein
Copy link
Member Author

We can start this after the asyncification of the query engine is done.

@schickling
Copy link
Member

schickling commented Oct 28, 2019

Note: Once this issue is complete, we need to address #68 in order to solve prisma/prisma#773

@dpetrick
Copy link
Contributor

dpetrick commented Nov 25, 2019

Task Breakdown [WIP]:
Core:

  • Schema must include a combination fields as unique criteria as per definition of the constraint.
  • Query parsing & validation: Investigate if changes are required.
  • Query graph: Investigate if changes are required.
  • RecordFinder (and possibly Filter) structs need to change so it can store a combined unique criteria.
  • Extensive testsuite required to cover all scenarios where multi field uniques can be used.

Connectors:

  • SQL connector implementation needs to change and adapt the multi field unique queries.

@dpetrick dpetrick closed this as completed Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants