feat: add push scalar list operation for update
#1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weakky
force-pushed
the
feat/scalar-list-push
branch
from
a1a8a5a
to
aeaceb2
Compare
dpetrick
approved these changes
Mar 19, 2021
| // .map(|f| self.model().fields().find_from_scalar(f.as_str()).unwrap()) | ||
| // .collect() | ||
| // } | ||
| // } else { |
There was a problem hiding this comment.
Seems like a leftover from the mongo PR, can be removed if you have time.
| @@ -168,7 +196,62 @@ class ScalarListsSpec extends FlatSpec with Matchers with ApiSpecBase { | |||
| |}""", | |||
| project = project, | |||
| errorCode = 2009, | |||
| errorContains = """`Mutation.createScalarModel.data.ScalarModelCreateInput.strings.ScalarModelCreatestringsInput.set`: A value is required but not set.""" | |||
There was a problem hiding this comment.
This is unexpected, how did the default type flip for Creates?
| model_name: String, | ||
| input_object_name: T, | ||
| f: ScalarFieldRef, | ||
| include_set_only: bool, |
There was a problem hiding this comment.
If you want to distinguish between update and create operation sets, then I suggest naming it accordingly.
is_create or similar, for example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes prisma/prisma#5078