Unescape string literals using pest instead of an ad-hoc regex #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
String unescaping now takes advantage of the parser already having done the work of figuring out where and what the escaped characters were, instead of trying to emulate this later with a regular expression.
tomhoule
force-pushed
the
datamodel-parser/deduplicate-string-literal-grammar-definition
branch
from
5309857
to
7b40caa
Compare
tomhoule
deleted the
datamodel-parser/deduplicate-string-literal-grammar-definition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String unescaping now takes advantage of the parser already having done
the work of figuring out where and what the escaped characters were,
instead of trying to emulate this later with a regular expression.