New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: json numeric filters (gt/gte/lt/lte) #2174

Merged

Weakky merged 1 commit into master from fix/json-numeric-compare-4

Aug 23, 2021

Member

Weakky commented Aug 23, 2021 •

edited

Overview

fixes JSON number filtering bug prisma#8224 (Postgres JSON numeric comparisons)
fixes MySQL and MariaDB JSON numeric comparisons too (fix(mysql): numeric comparison with json_extract quaint#310, fix(mysql): json numeric comparisons on both sides quaint#311, fix(mariadb): json gt/gte/lt/lte comparisons quaint#315)
have JSON filter tests actually run again

Deeper dive

On Postgres, we were applying ASCII comparison instead of numeric comparison
On MySQL and MariaDB, we're doing the comparisons against the deserialized json values


          fix: json numeric filters (gt/gte/lt/lte)

eb66bc5

Weakky added this to the 2.30.0 milestone

Weakky merged commit b7504af into master

Weakky deleted the fix/json-numeric-compare-4 branch

August 23, 2021 18:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment