Remove residual NamedConstraint gating #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhoule
force-pushed
the
named-constraint-forgotten-gates
branch
7 times, most recently
from
5da5746
to
50233b0
Compare
tomhoule
changed the title
tomhoule
force-pushed
the
named-constraint-forgotten-gates
branch
2 times, most recently
from
295f998
to
96f5c12
Compare
tomhoule
force-pushed
the
named-constraint-forgotten-gates
branch
3 times, most recently
from
3bef1ff
to
cbc229d
Compare
In particular: - Foreign key constraint names were not rendered in introspection - Default constraint names were not diffed in migrations
tomhoule
force-pushed
the
named-constraint-forgotten-gates
branch
from
cbc229d
to
de76a9d
Compare
pimeys
approved these changes
Sep 2, 2021
| use barrel::types; | ||
| use enumflags2::BitFlags; | ||
| use expect_test::expect; | ||
| use introspection_engine_tests::test_api::*; | ||
| use introspection_engine_tests::TestResult; | ||
| use test_macros::test_connector; | ||
|
|
||
| #[test_connector(exclude(Mysql, Mssql))] | ||
| #[test_connector(exclude(Mysql, Mssql, Sqlite))] |
| @@ -131,7 +131,10 @@ async fn a_one_to_one_relation(api: &TestApi) -> TestResult { | |||
| t.add_column("id", types::integer().increments(true)); | |||
| t.add_column("user_id", types::integer().nullable(true)); | |||
|
|
|||
| t.add_foreign_key(&["user_id"], "User", &["id"]); | |||
| t.add_constraint( | |||
There was a problem hiding this comment.
ngggh this API from Barrel (I wrote). We should maybe just stop using it...
This was referenced Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular: