fix: 9132, MySQL now respect param bind limit #2293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weakky
approved these changes
Oct 6, 2021
|
@Weakky That will involve regressions for other engines as well (they have limits too), do you think that would be ok? |
dpetrick
suggested changes
Oct 18, 2021
query-engine/connector-test-kit-rs/query-engine-tests/tests/new/limits.rs
Outdated
Show resolved
Hide resolved
- Originally MySQL didn't have a limit for the number of parameters to bind to - Now it will respect the limit in MySQL source code (`UINT_MAX16`)
- Different databases has different limits - This tests already set limits
- Remove useless limit test as suggested in PR - Update readme file with correct Rust compiler version
dpetrick
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bind to
UINT_MAX16)