-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent cyclic actions on emulated references #2415
Merged
Weakky
merged 6 commits into
master
from
parser-database/emulated-cycles-should-not-be-allowed
Dec 17, 2021
Merged
Prevent cyclic actions on emulated references #2415
Weakky
merged 6 commits into
master
from
parser-database/emulated-cycles-should-not-be-allowed
Dec 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpetrick
approved these changes
Nov 15, 2021
pimeys
force-pushed
the
parser-database/emulated-cycles-should-not-be-allowed
branch
from
November 30, 2021 13:45
ae0bd54
to
50545b4
Compare
Weakky
force-pushed
the
parser-database/emulated-cycles-should-not-be-allowed
branch
from
December 15, 2021 10:55
50545b4
to
48648ac
Compare
dpetrick
approved these changes
Dec 15, 2021
let schema = indoc! { | ||
r#"model User { | ||
#id(id, Int, @id) | ||
idd Int @unique |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a fan of the naming, something like uniq
makes it clearer what is happening.
Weakky
deleted the
parser-database/emulated-cycles-should-not-be-allowed
branch
December 17, 2021 13:45
tomhoule
pushed a commit
that referenced
this pull request
Dec 20, 2021
Co-authored-by: Flavian DESVERNE <flavian.desverne@epitech.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: prisma/prisma#9931