Force Cloudflare DNS with MongoDB connections on Windows #2694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimeys
force-pushed
the
introspection/windows-resolver-fix
branch
from
b765b29
to
de3cd8e
Compare
pimeys
force-pushed
the
introspection/windows-resolver-fix
branch
from
de3cd8e
to
32a9458
Compare
Adding a new crate to unify Mongo client creation everywhere in Prisma. Also gets handy when we need to parse multiple replicas in the string. On Windows, the trust-dns-resolver is VERY slow if not giving it the DNS server what to use. We for now solve it by resolving with Cloudflare. We know already this will break in companies that do not allow resolving outside of the company DNS, and in countries that are either banned from Cloudflare or do not allow using their services. Issue to follow: hickory-dns/hickory-dns#1636
pimeys
force-pushed
the
introspection/windows-resolver-fix
branch
from
32a9458
to
a8c9841
Compare
janpio
approved these changes
Feb 17, 2022
pimeys
changed the title
tomhoule
approved these changes
Feb 17, 2022
There was a problem hiding this comment.
Also relevant: #2695
My only nitpick is that it feels like something we could reexport the mongodb crate from, so we don't need two dependencies for mongo everywhere. I get that it would change the imports so it might be tedious to do now.
|
We'll do that eventually. It's a good idea. |
|
Can you make sure #2695 is expanded to all usages and the now existing conflict is fixed? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new crate to unify Mongo client creation everywhere in Prisma. Also
gets handy when we need to parse multiple replicas in the string.
On Windows, the trust-dns-resolver is VERY slow if not giving it the DNS server
what to use. We for now solve it by resolving with Cloudflare. We know already
this will break in companies that do not allow resolving outside of the company
DNS, and in countries that are either banned from Cloudflare or do not allow
using their services.
Issue to follow: hickory-dns/hickory-dns#1636
Closes: prisma/prisma#11340