me: Make migrations not depend on default_int_size param #2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimeys
reviewed
Mar 9, 2022
| PostgresType::Integer => "INTEGER".into(), | ||
| PostgresType::Integer => { | ||
| if flavour.is_cockroachdb() { | ||
| "INT4".into() |
There was a problem hiding this comment.
Are we sure we want INT4 keys always with CockroachDB?
|
I'll develop more in the commit message, but the gist of it is that we have On Postgres, we map On cockroachdb before this commit, we map |
pimeys
approved these changes
Mar 9, 2022
The gist of this commit is that we have Int and Bigint in the PSL. On all connectors, Int means 32 bit signed integer, and BigInt means 64 bit signed integer. On Postgres, we map Int to INTEGER in a create table, and that's good and accurate. On cockroachdb before this commit, we map Int to INTEGER, but the size of INTEGER depends on the default_int_size configuration (session or server) param, and by default it's 8. This commit goes around that by mapping int to INT4 to reflect Prisma expectations. BigInt is still mapped to BIGINTEGER, which is correct. We use the cockroach-specific `INT4` to avoid integer sizing ambiguities. For the complete solution, we will have to deal with the different type of autoincrementing primary keys, because two out of the there force INT8. Addresses the default_int_size part of prisma/prisma#12113
tomhoule
force-pushed
the
me/cockroachdb-default-create-tables
branch
from
fd90b8a
to
918d142
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the cockroach-specific
INT4to avoid integer sizingambiguities. For the complete solution, we will have to deal with the
different type of autoincrementing primary keys, because two out of the three
that exist force INT8.
Addresses the default_int_size part of prisma/prisma#12113