Implement scalar list defaults proposal #2946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhoule
force-pushed
the
p4-scalar-list-defaults
branch
7 times, most recently
from
377d7ce
to
ee3922b
Compare
janpio
reviewed
Jun 1, 2022
tomhoule
force-pushed
the
p4-scalar-list-defaults
branch
8 times, most recently
from
70cfba5
to
6ec00ea
Compare
tomhoule
force-pushed
the
p4-scalar-list-defaults
branch
3 times, most recently
from
9a9e45c
to
dd0f5c1
Compare
tomhoule
changed the title
tomhoule
force-pushed
the
p4-scalar-list-defaults
branch
from
dd0f5c1
to
b10480c
Compare
dpetrick
reviewed
Jun 17, 2022
migration-engine/connectors/sql-migration-connector/src/sql_schema_differ/column.rs
Outdated
Show resolved
Hide resolved
...nnectors/sql-migration-connector/src/sql_schema_differ/sql_schema_differ_flavour/postgres.rs
Outdated
Show resolved
Hide resolved
Jolg42
reviewed
Jun 17, 2022
introspection-engine/introspection-engine-tests/tests/tables/cockroachdb.rs
Outdated
Show resolved
Hide resolved
Jolg42
reviewed
Jun 17, 2022
...nnectors/sql-migration-connector/src/sql_schema_differ/sql_schema_differ_flavour/postgres.rs
Outdated
Show resolved
Hide resolved
Jolg42
reviewed
Jun 17, 2022
.../sql-schema-describer/tests/describers/postgres_describer_tests/cockroach_describer_tests.rs
Outdated
Show resolved
Hide resolved
refactor(parserdb): improve validation of dbgenerated() feat: implement scalar list defaults proposal in schema Following components: sql-schema-describer, introspection engine and migration engine.
Query engine scalar list defaults (#2978) * First (failing, of course) test. * Add missing json scalar list tests. Separate tests. * Implement QE-side list defaults * Cockroach investigation
- simplify regular defaults in postgres describer - finish scalar list defaults introspection - scalar list diffing in migrations - Progress: fix byte defaults, parse different types of array syntaxes
Re-enable cockroach for QE defaults base test.
tomhoule
force-pushed
the
p4-scalar-list-defaults
branch
from
b10480c
to
2e8e65f
Compare
tomhoule
commented
Jun 21, 2022
introspection-engine/connectors/sql-introspection-connector/src/defaults.rs
Outdated
Show resolved
Hide resolved
introspection-engine/introspection-engine-tests/tests/tables/cockroachdb.rs
Show resolved
Hide resolved
migration-engine/connectors/sql-migration-connector/src/sql_renderer/postgres_renderer.rs
Show resolved
Hide resolved
migration-engine/connectors/sql-migration-connector/src/sql_schema_calculator.rs
Outdated
Show resolved
Hide resolved
migration-engine/connectors/sql-migration-connector/src/sql_schema_differ/column.rs
Show resolved
Hide resolved
migration-engine/migration-engine-tests/tests/migrations/postgres.rs
Outdated
Show resolved
Hide resolved
migration-engine/migration-engine-tests/tests/migrations/postgres.rs
Outdated
Show resolved
Hide resolved
tomhoule
force-pushed
the
p4-scalar-list-defaults
branch
from
5e391cb
to
0b09d65
Compare
squashed: - Address review feedback
tomhoule
force-pushed
the
p4-scalar-list-defaults
branch
from
0b09d65
to
a10a3d5
Compare
|
Note: it's out in |
aqrln
added a commit
to prisma/prisma
that referenced
this pull request
Jun 23, 2022
Ref: #13321 Ref: prisma/prisma-engines#2946 Ref: #13912 Ref: #13934
aqrln
added a commit
to prisma/prisma
that referenced
this pull request
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes prisma/prisma#13320
closes prisma/prisma#13322
closes prisma/prisma#8330
closes prisma/prisma#13319