Fix block attribute doc comment reformatting #3030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhoule
force-pushed
the
schema-ast/pure-reformatter
branch
2 times, most recently
from
bffb615
to
8cbc3fd
Compare
tomhoule
changed the title
tomhoule
force-pushed
the
schema-ast/pure-reformatter
branch
2 times, most recently
from
7b0b77c
to
b1d94f6
Compare
tomhoule
force-pushed
the
schema-ast/pure-reformatter
branch
4 times, most recently
from
63ab71a
to
a1b2a66
Compare
This is achieved by a massive cleanup and simplification of the AST reformatter. - The comments attached to block attributes will follow them after reformatting. - Enum attributes do not get reformatted with an extra leading space anymore - Empty lines at beginning and end of blocks are reformatted away. closes prisma/language-tools#1186 Also included: - diagnostics: delete dead warnings code and stop using thiserror — compile times will thank us.
tomhoule
force-pushed
the
schema-ast/pure-reformatter
branch
from
a1b2a66
to
c648aee
Compare
|
Reviewed in person with @pimeys . |
This was referenced Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix block attribute doc comment reformatting
This is achieved by a massive cleanup and simplification of the
AST reformatter.
reformatting.
anymore
closes prisma/language-tools#1186
Also included:
compile times will thank us.