New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add "denoDeploy" preview feature flag for client #3094
Conversation
Note: related to prisma/prisma#14386 Slack: https://prisma-company.slack.com/archives/C03MQBP84E6/p1659032973203539 |
I think this change is necessary for continuing the work at prisma/prisma#14386. PTAL @millsp @matthewmueller |
@@ -5,7 +5,7 @@ use std::fmt; | |||
macro_rules! features { | |||
($( $variant:ident $(,)? ),*) => { | |||
#[enumflags2::bitflags] | |||
#[repr(u32)] | |||
#[repr(u64)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to change this because DenoDeploy
is the 33rd flag and I saw the error Not enough bits for 33 flags
with repr(u32)
@garrensmith can you please create an integration version for @kt3k (if not already)? |
Is there anything I can do to help this get merged? |
@millsp Thanks! |
Hey @kt3k here's the integration version. This is basically our main branch with the engines that you've modified in this PR. You can directly update the engines versions in your own TypeScript PR. Just run |
We decided to switch to using |
This is a preliminary work for Deno Deploy support of prisma client. We're going to implement Deno Deploy specific feature under this feature flag. (Please see the prisma/deno shared channel for more context.)