Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "denoDeploy" preview feature flag for client #3094

Closed
wants to merge 5 commits into from

Conversation

kt3k
Copy link

@kt3k kt3k commented Aug 2, 2022

This is a preliminary work for Deno Deploy support of prisma client. We're going to implement Deno Deploy specific feature under this feature flag. (Please see the prisma/deno shared channel for more context.)

@kt3k kt3k requested a review from a team as a code owner August 2, 2022 08:21
@CLAassistant
Copy link

CLAassistant commented Aug 2, 2022

CLA assistant check
All committers have signed the CLA.

@Jolg42
Copy link
Member

Jolg42 commented Aug 2, 2022

@kt3k
Copy link
Author

kt3k commented Aug 23, 2022

I think this change is necessary for continuing the work at prisma/prisma#14386. PTAL @millsp @matthewmueller

@@ -5,7 +5,7 @@ use std::fmt;
macro_rules! features {
($( $variant:ident $(,)? ),*) => {
#[enumflags2::bitflags]
#[repr(u32)]
#[repr(u64)]
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to change this because DenoDeploy is the 33rd flag and I saw the error Not enough bits for 33 flags with repr(u32)

@garrensmith garrensmith added this to the 4.3.0 milestone Aug 24, 2022
@janpio janpio removed this from the 4.3.0 milestone Aug 24, 2022
@millsp
Copy link
Member

millsp commented Aug 29, 2022

@garrensmith can you please create an integration version for @kt3k (if not already)?

@kt3k
Copy link
Author

kt3k commented Aug 31, 2022

Is there anything I can do to help this get merged?

@millsp
Copy link
Member

millsp commented Aug 31, 2022

Hey @kt3k we can't merge this as-is yet otherwise the preview feature would show up to our users (if we release). What we can do is to release an integration of this for you to work with in the client. Triggered here #3161. I'll send you extra instructions when this is out.

@kt3k
Copy link
Author

kt3k commented Aug 31, 2022

@millsp Thanks!

@millsp
Copy link
Member

millsp commented Aug 31, 2022

Hey @kt3k here's the integration version. This is basically our main branch with the engines that you've modified in this PR. You can directly update the engines versions in your own TypeScript PR. Just run pnpm run bump-engines 4.4.0-4.integration-deno-preview-flag-3c1168fbf77b17ded4f89a480e467eddb5302d77 in the monorepo, and it will install the built engines of current PR.

@janpio
Copy link
Member

janpio commented Oct 14, 2022

We decided to switch to using deno as the preview feature.
I quickly recreated this PR as #3291 and it was merged.

@janpio janpio closed this Oct 14, 2022
@kt3k kt3k deleted the deno-deploy-preview-feature-flag branch October 15, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants