feat(relation-mode): remove emulated `NoAction` for `postgres` and `sqlite` #3274

jkomyno · 2022-10-11T00:27:01Z

With this PR:

NoAction becomes invalid for PostgreSQL and SQLite when relationMode = "prisma" with a standard validation message, e.g.:

Invalid referential action: NoAction. Allowed values: (Cascade, ...)
When relationMode = "prisma", NoAction is not supported, but Restrict is supported, the same validation error message show above provides a bit more information:

Invalid referential action: NoAction. Allowed values: (Cascade, Restrict, SetNull). NoAction is not implemented for $DATABASE_NAME when using relationMode = "prisma", you could try using Restrict instead. Learn more at https://pris.ly/d/relationMode

Note: At the time being, the only databases that don't support NoAction (postgres, sqlite) also support Restrict, so the second validation message - the more complete one - will be shown rather than the first.

Contributes to prisma/prisma#15655.

…n referential action

…eferential_actions_default', remove support for simulated NoAction for postgres and sqlite

…alidating referential actions

psl/psl-core/src/datamodel_connector.rs

psl/builtin-connectors/src/cockroach_datamodel_connector.rs

psl/psl-core/src/validate/validation_pipeline/validations/relation_fields.rs

tomhoule

Looks good on the whole 👍 The only important comments I left are the ones about documenting things.

psl/psl-core/src/datamodel_connector.rs

psl/builtin-connectors/src/cockroach_datamodel_connector.rs

psl/builtin-connectors/src/mysql_datamodel_connector.rs

psl/psl/tests/attributes/relations/referential_actions.rs

psl/psl-core/src/validate/validation_pipeline/validations/relation_fields.rs

…l_core::datamodel_connector::Connector

psl/psl-core/src/datamodel_connector.rs

psl/psl-core/src/validate/validation_pipeline/validations/relation_fields.rs

tomhoule

few more comments

…ns()'

jkomyno · 2022-10-11T14:35:34Z

(Flaky cockroachdb suite on Buildkite)

tomhoule

approved with changes made on zoom

Related prisma/prisma-engines#3274

@ts-expect-error

…tabases (#14221) * test(client): prototype referential integrity tests Related: #10806 Test Suites: 1 failed, 1 total Tests: 3 failed, 45 passed, 48 total Snapshots: 0 total Time: 9.838 s * exclude mongodb to see if types tests fail like locally * wip rewrite with Alberto * chore: update tests * chore: used .rejects.toThrowError * chore: started adding ref actions * chore: mongodb only supports 'referentialIntegrity: prisma' * chore: added support for conditional error messages * wip reorg with describe revert matrix and schema changes beforeEach check and create users with profiles * fix referentialIntegrityLine * add skeleton for 1:n and m:n tests * chore: highlighted some test errors with mongodb * chore: added create tests for 1:n relationship * chore: added TODO comment * WIP m:n for SQL databases * ci: try running github actions matrix with our tests only * ci: remove needs: detect_jobs_to_run * ci: fix os matrix * ci: small CI env var tweak * ci: fix bash line * chore: added some update/delete tests for 1:n * chore: added comments to _matrix.ts * postgresql m:n all referential actions * merge main * DEFAULT, exclude Restrict from SQL Server, fix tests * add mongodb tests for m:n * chore: added some additional ref actions, added support for SQL Server * chore: fixed bug with DEFAULT not tested, added upsert test, fixed some conditional errors, found panic on SQLServer with SetDefault * reuse sql schema for mongodb 1:1 1:n * 1:1 test all referral actions for onDelete & clean * chore: improved ref actions, fixed failing tests * chore: reproduced issue #14271 * chore: split relationships in separate files * split m:n mongodb tests into its own file * add `enabled Boolean?` on 1-to-n It's a reproduction of #13766 * m:n add comments where RI=prisma - Cascade resolves instead of failing in update and create * add `published Boolean?` to MongoDB and update tests * 1:1 add `enabled Boolean?` and MongoDB update tests * add `published Boolean?` to m:n with update tests * chore: updated sql server tests * add comments to m:n [skip ci] * add a mongodb test for immutable _id * full database matrix for CI * split schemas into simple files * m to n MongoDB: change tests to match current implementation expectations * chore: add JSON support to getTestSuiteFullName * chore: moved ref integrity utils to its own folder. Added builder pattern to conditional error. Added matrix generation. Extracted self-contained utilities out of _schema.ts file. * chore: added sqlite support and referentialIntegrity=prisma snapshots to 1:1 and 1:n relations * chore: pnpm-lock * chore: removed temp folder that wasn't supposed to be committed * chore: imported right 'checkIfEmpty' util for m:n relation * clean and add sqlite on m to n * m to n add RI=Prisma messages as comments + small edits add expectation even for `toThrowError()` cases * m:n: split 1 test for prisma/foreignKeys * chore: added prisma snapshots and errors as comments in m:n relation (no MongoDB yet) * chore: added mongodb and comments to _matrix * fix: moved _referential-integrity-utils to _utils/referential-integrity to support ERR_PNPM_NO_SCRIPT Missing script: test:functional-code command * update matrix for MongoDB: add SetNull * chore: added comments to m:n * m to n: small edits for RI=prisma * test 1:1 / 1:n add expects for expected throws and fix some RI=prisma messages * chore: prettier * 1:1 handle error messages depending on RI=prisma/foreignKeys * * simplify conditionals * m to n: change expectations to match current state * chore: comment skipped test * sqlite: skip createMany in 1:n relations * chore: added missing sqlite snapshots to 1:n relation * 1:n add missing delete action variants * 1:n simplify and handle expected RI=prisma tests that should succeed * chore: added reproduction of issue #10000 * chore: updated reproduction of issue #10000 * chore: reproduce issue #12378 * 1:1 separate onUpdate: Restrict, NoAction * 1:1 fix create test from should throw to should succeed * ci: separate action test for each relation / file * ci: continue-on-error: true * fix: referential actions test params * fix ts checks * only run pnpm run test:functional:code filename * fix Cannot destructure property 'onDelete' of 'suiteConfig.referentialActions' as it is undefined. * chore: added reproduction of issue #12557 * chore: add assertions to nested child connect in 1:1 * chore: clean unused code and better describe title * test: add test about NO ACTION behavior with DEFERRABLE constraint * manually bump engines * chore: rename referentialIntegrity datasource property to relationMode * fix github actions * fix test about 14759 and RELATION_MODE env var * cleanup some reproduce-x test cases * add sqlite error snapshot * remove continue-on-error * remove outdated comments * ci: remove last continue-on-error: true * test: add `SetNull` to the matrix only for relationMode=prisma * ci: add continue-on-error: true to run all tests * fix snapshot with lowerace table name and run SQL Server * exclude SQL Server / SetNull when relationMode !== prisma * fix computeMatrix for SQL Server Restrict emulation which is not implemented * change failing tests (issue 15683) to use .failing * fix SQL Server test * test(reproductions): fix empty test name * fix relationMode = prisma SQL Server error snapshot * fix relationMode = prisma SQL Server error snapshot * fix relationMode = prisma SQL Server error snapshot * comment vitess docker image (unused) and put back timeout to 60s * test: fix snapshots for field-reference * test: fix snapshot and getTestSuiteParametersString * ignore expected type errors * add note about SetNull is not run for foreignKeys in the test suite * test: tweak comment and fix 1:1 test snapshots * Unused '@ts-expect-error' directive. * add `--relation-mode-tests-only` to unblock merge * test: skip NoAction for PostgreSQL and SQLite Related prisma/prisma-engines#3274 * fix relationMode value * fix test name + comments * cleanup matrix and move reproduce tests to issues directory * add test for referentialIntegrity="prisma" Closes #15736 * cleanup comments and misleading `toThrowError()` for expected to fail tests * chore: removed useless comment * chore: removed useless comments * fix imports for moved tests in issues directory Co-authored-by: jkomyno <skiabo97@gmail.com> Co-authored-by: Alberto Schiabel <jkomyno@users.noreply.github.com>

jkomyno added 6 commits October 11, 2022 02:13

test: added tight actions_on_'db'_with_prisma_relation_mode tests

38d56a3

test: check that neither postgres or sqlite support simulated NoActio…

be3fc80

…n referential action

feat: replace 'allowed_referential_actions' with 'allowed_simulated_r…

1545fee

…eferential_actions_default', remove support for simulated NoAction for postgres and sqlite

up

e4103b0

feat(psl): distinguish between 'foreignKeys' and 'prisma' mode when v…

dc0871f

…alidating referential actions

chore: improved formatting

2e08a72

jkomyno mentioned this pull request Oct 11, 2022

Integration: remove simulated NoAction for postgres and sqlite #3275

Closed

jkomyno added this to the 4.5.0 milestone Oct 11, 2022

jkomyno changed the title ~~feat/remove simulated NoAction for postgres and sqlite~~ feat(relation-mode): remove simulated NoAction for postgres and sqlite Oct 11, 2022

jkomyno commented Oct 11, 2022

View reviewed changes

psl/psl-core/src/datamodel_connector.rs Outdated Show resolved Hide resolved

jkomyno added 2 commits October 11, 2022 03:28

chore: fix clippy

6aba8c9

chore: fix clippy

5baab1a

jkomyno mentioned this pull request Oct 11, 2022

Integration: fix prisma/prisma#15655 #3277

Draft

chore: fix clippy

e235b79

Jolg42 self-requested a review October 11, 2022 07:32

Jolg42 reviewed Oct 11, 2022

View reviewed changes

psl/builtin-connectors/src/cockroach_datamodel_connector.rs Outdated Show resolved Hide resolved

Jolg42 reviewed Oct 11, 2022

View reviewed changes

psl/psl-core/src/validate/validation_pipeline/validations/relation_fields.rs Outdated Show resolved Hide resolved

chore: address PR comments

d33c4cb

jkomyno changed the title ~~feat(relation-mode): remove simulated NoAction for postgres and sqlite~~ feat(relation-mode): remove emulated NoAction for postgres and sqlite Oct 11, 2022

jkomyno marked this pull request as ready for review October 11, 2022 08:47

jkomyno requested a review from a team as a code owner October 11, 2022 08:47

jkomyno mentioned this pull request Oct 11, 2022

fix(qe): NoAction should be alias of Restrict when relationMode = "prisma" #3276

Merged

tomhoule reviewed Oct 11, 2022

View reviewed changes

jkomyno added 2 commits October 11, 2022 14:14

chore: address PR comments

c8c7f53

chore: moved default definition of emulated_referential_actions to ps…

02a5f89

…l_core::datamodel_connector::Connector

tomhoule reviewed Oct 11, 2022

View reviewed changes

psl/psl-core/src/datamodel_connector.rs Show resolved Hide resolved

psl/psl-core/src/validate/validation_pipeline/validations/relation_fields.rs Outdated Show resolved Hide resolved

psl/psl-core/src/validate/validation_pipeline/validations/relation_fields.rs Outdated Show resolved Hide resolved

tomhoule reviewed Oct 11, 2022

View reviewed changes

jkomyno added 2 commits October 11, 2022 15:42

chore: addressed PR comments

16346c7

chore: dropped 'relation_mode' argument on 'emulate_referential_actio…

1dcc9ba

…ns()'

tomhoule approved these changes Oct 11, 2022

View reviewed changes

jkomyno added 2 commits October 11, 2022 16:50

chore: addressed PR suggestions on zoom

beb9e1e

chore: updated error message in tests

5755b7a

jkomyno merged commit f6d71ec into main Oct 11, 2022

jkomyno deleted the feat/remove-simulated-noaction-for-postgres-and-sqlite branch October 11, 2022 16:04

Jolg42 added a commit to prisma/prisma that referenced this pull request Oct 12, 2022

test: skip NoAction for PostgreSQL and SQLite

1c6f5bd

Related prisma/prisma-engines#3274

jkomyno mentioned this pull request Oct 17, 2022

referentialIntegrity/relationMode preview feature (referentialIntegrity = "prisma"): Make NoAction a synonym/alias of Restrict for the emulation, for all databases except PostgreSQL & SQLite. prisma/prisma#15655

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(relation-mode): remove emulated `NoAction` for `postgres` and `sqlite` #3274

feat(relation-mode): remove emulated `NoAction` for `postgres` and `sqlite` #3274

jkomyno commented Oct 11, 2022 •

edited

tomhoule left a comment

tomhoule left a comment

jkomyno commented Oct 11, 2022

tomhoule left a comment

feat(relation-mode): remove emulated NoAction for postgres and sqlite #3274

feat(relation-mode): remove emulated NoAction for postgres and sqlite #3274

Conversation

jkomyno commented Oct 11, 2022 • edited

tomhoule left a comment

Choose a reason for hiding this comment

tomhoule left a comment

Choose a reason for hiding this comment

jkomyno commented Oct 11, 2022

tomhoule left a comment

Choose a reason for hiding this comment

feat(relation-mode): remove emulated `NoAction` for `postgres` and `sqlite` #3274

feat(relation-mode): remove emulated `NoAction` for `postgres` and `sqlite` #3274

jkomyno commented Oct 11, 2022 •

edited